1.5-pre2 (and prior) infinite loop

[J]

KMess hangs using all CPU it can get when a chat window is opened or something like that. I believe the following code in kmess/network/msnnotificationconnection.cpp is responsible for the bug at hand:

Code: Select all

void MsnNotificationConnection::requestChat(QString handle)
{
  QPtrListIterator<ChatInformation> it(openChats_);
  while( it.current() != 0 )
  {
    if( it.current()->getContactHandle() == handle )
    {
#ifdef KMESSDEBUG_NOTIFICATION
      kdDebug() << "MsnNotificationConnection::requestChat: Already have a
chatconversation with '" << handle << "' pending." << endl;
#endif
      return;
    }
  }

The iterator "it" is not being incremented!!!

(Gentoo bug #172018)

[vdboor]

Confirmed, and changed in my local copy too. I'll commit this once we've migrated to SVN. Thanks for reporting this, I didn't run into this bug yet!

FYI: this bug is trigged when you try to open/resume 2 chats at the same time (or still have one pending).

Weird to see what bug as WONTFIX btw..

[vdboor]

The fix is in subversion, for KMess 1.5!