Patch for ticket #479 - Change user's picture with Drag&Drop

Post your own changes and improvements to the KMess source code here.

Patch for ticket #479 - Change user's picture with Drag&Drop

Postby Mentos » December 30th, 2009, 5:32 am

i have created a patch for the ticket #479 (http://trac.kmess.org/ticket/479)

works fine with the picture in the contact list, in chat window, and works also for the picture of other contacts.

But to do this i had to duplicate some code from accountpage.cpp related to the picture's creation, and between pictures for drag&drop handling :? .

Suggestions?

Also, i've fixed a little bug: changing the contacts' pictures with an own image (and viceversa) the pictureChanged() signal was not emitted, and the existing picture in chat window was not updated.

http://mentos.homelinux.org/patches/dnd-chat-contactframe.cpp.diff
http://mentos.homelinux.org/patches/dnd-chat-contactframe.ui.diff
http://mentos.homelinux.org/patches/dnd-chat-contactswidget.cpp.diff
http://mentos.homelinux.org/patches/dnd-chat-contactswidget.ui.diff
http://mentos.homelinux.org/patches/dnd-contactlist-kmessview.cpp.diff
http://mentos.homelinux.org/patches/dnd-contactlist-kmessview.ui.diff
http://mentos.homelinux.org/patches/fix-picture-refresh-contactextension.cpp.diff
Mentos
 
Posts: 8
Joined: December 28th, 2009, 3:23 am
Location: Varese, Italia

Re: Patch for ticket #479 - Change user's picture with Drag&Drop

Postby Valerio » January 2nd, 2010, 4:26 pm

This is very very nice! I'll check and commit this patchset right now :O Thank you!

For 2.1 the codebase is quite better, we have a widget dedicated to showing DPs; we could add a Contact reference to self or a contact to it, to enable this same feature quite more easily :)

(ps this means this code can't be committed to 2.1 as well as 2.0.x)
Image
User avatar
Valerio
Developer (*)
 
Posts: 1698
Joined: February 20th, 2007, 1:25 am
Location: Italy - Sardinia


Return to Patches



Who is online

Users browsing this forum: No registered users and 1 guest

cron